Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChunkCsvInput data_type of chunk #223

Merged
merged 2 commits into from
May 27, 2024
Merged

Fix ChunkCsvInput data_type of chunk #223

merged 2 commits into from
May 27, 2024

Conversation

dachengx
Copy link
Contributor

Before you submit this PR: make sure to put all XENONnT specific information in a wiki-note as the repo is publicly accessible

What does the code in this PR do / what does it improve?

data_type of ChunkInput should not be "geant4_interactions"

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Bump plugin version(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the GitHub open issues?

@coveralls
Copy link

coveralls commented May 19, 2024

Pull Request Test Coverage Report for Build 9225512977

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.07%

Totals Coverage Status
Change from base Build 9225501769: 0.0%
Covered Lines: 2314
Relevant Lines: 2964

💛 - Coveralls

@HenningSE
Copy link
Collaborator

Hi @dachengx, what is the reason for removing this?

@dachengx
Copy link
Contributor Author

Hi @dachengx, what is the reason for removing this?

It is not necessary. The data_type of the chunk will be deduced by Plugin.chunk automatically.

And data_type of ChunkInput should not be "geant4_interactions".

@HenningSE HenningSE merged commit 7af247a into main May 27, 2024
4 checks passed
@HenningSE HenningSE deleted the data_type_csv_input branch May 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants