Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to replace maps by constant dummy map #262

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Conversation

HenningSE
Copy link
Collaborator

What does the code in this PR do / what does it improve?

This PR adds a URLConfig protocol, creating a dummy map returning constant values. The DummyMap code is taken from WFSim.

@HenningSE HenningSE marked this pull request as ready for review September 12, 2024 12:29
Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @HenningSE! Merging now.

@ramirezdiego ramirezdiego merged commit 49c8bde into main Sep 17, 2024
3 of 4 checks passed
@ramirezdiego ramirezdiego deleted the dummy_map_option branch September 17, 2024 07:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10898531897

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 17 (35.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 80.188%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fuse/context.py 6 17 35.29%
Totals Coverage Status
Change from base Build 10830815049: -0.2%
Covered Lines: 2562
Relevant Lines: 3195

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants