Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression fix on using relative paths #248

Merged
merged 9 commits into from
Jan 6, 2019
Merged

Performance regression fix on using relative paths #248

merged 9 commits into from
Jan 6, 2019

Commits on Jan 2, 2019

  1. Apply @Property to SurveyElement.__name__(). 

    Class method __name_ should be a property.
    @ukanga
    ukanga committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    d4e6d59 View commit details
    Browse the repository at this point in the history

  2. Make SurveyElement hashable. 

    Will allow use of lru_cache devorator.
    @ukanga
    ukanga committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    621863a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Apply lru_cache() decorator to survey.is_a_parent() function. 

    This reduces the time by more than half i.e 46s down to 16s. It is still
4 times more than v0.11.5.

Fix XLSForm#247
    @ukanga
    ukanga committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    41f2c4b View commit details
    Browse the repository at this point in the history

  2. Refactor: add survey.any_repeat() method 

    Returns True on first repeat occurance and caches with lru_cache.

Part fix for XLSForm#247
    @ukanga
    ukanga committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    28b1947 View commit details
    Browse the repository at this point in the history

  3. Only check share same repeat parent when the base parents are the same.

    @ukanga
    ukanga committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    7fdb674 View commit details
    Browse the repository at this point in the history

  4. Add python 2.7 required functools32 to setup.py.

    @ukanga
    ukanga committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    b30ebbb View commit details
    Browse the repository at this point in the history

  5. Update CHANGES.txt

    @ukanga
    ukanga committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    6ccf57a View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Do not apply relative path to indexed-repeat() expressions.

    @ukanga
    ukanga committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    4380bf5 View commit details
    Browse the repository at this point in the history

  2. Code cleanup

    @ukanga
    ukanga committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    b499446 View commit details
    Browse the repository at this point in the history