Clear Invalid Filename Error Message #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincmba
force-pushed
the
22-clear-filename-error-message
branch
from
c1acab7
to
4e61a28
Compare
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
========================================
+ Coverage 81.19% 81.3% +0.1%
========================================
Files 23 23
Lines 3106 3108 +2
Branches 729 729
========================================
+ Hits 2522 2527 +5
+ Misses 450 448 -2
+ Partials 134 133 -1
Continue to review full report at Codecov.
|
lincmba
force-pushed
the
22-clear-filename-error-message
branch
from
31f8375
to
94d1656
Compare
Signed-off-by: Lincoln Simba <[email protected]>
ukanga
requested changes
May 5, 2019
pyxform/survey_element.py
Outdated
| " include numbers, dashes, and periods." % self.name | ||
| invalid_char = re.search(INVALID_XFORM_TAG_REGEXP, self.name) | ||
| msg = "Invalid name. Remove '{}' from '{}'".format( | ||
| invalid_char.group(0), self.name) |
There was a problem hiding this comment.
Let's retain a bit of the original message, but show the offending characters. For example, The name 'badfile@name' is an invalid XML tag, it contains invalid character(s) '@'. Names must begin with a letter, colon, or underscore, subsequent characters can include numbers, dashes, and periods.
Signed-off-by: Lincoln Simba <[email protected]>
lincmba
force-pushed
the
22-clear-filename-error-message
branch
from
9f5fc1c
to
f4728bf
Compare
ukanga
approved these changes
May 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a clear error message. State exact error, if a filename is invalid.
Fixes #22