Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLS-20 spec: #95

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Add XLS-20 spec: #95

merged 5 commits into from
Mar 21, 2023

Conversation

shawnxie999
Copy link
Collaborator

@shawnxie999 shawnxie999 commented Mar 10, 2023

Latest version: XLS-20 Non-Fungible Tokens

Added raw content from XLS-20 spec discussion in the first commit.

The spec is updated as of the rippled v.1.10 release. Updates made in addition to the original spec in second commit

Fixes #86.

@shawnxie999 shawnxie999 marked this pull request as draft March 10, 2023 19:22
@shawnxie999 shawnxie999 force-pushed the xls-20 branch 5 times, most recently from 1088cec to e28a161 Compare March 13, 2023 19:02
@shawnxie999 shawnxie999 changed the title Add original XLS-20 spec Add XLS-20 spec Mar 13, 2023
@shawnxie999 shawnxie999 marked this pull request as ready for review March 13, 2023 19:37
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@DennisDawson DennisDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify line 594, which I believe is erroneous. Consider the punctuation and style suggestions.

XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
@intelliot intelliot requested a review from Silkjaer March 15, 2023 23:17
@intelliot intelliot changed the title Add XLS-20 spec Add XLS-20 spec (fix #86) Mar 16, 2023
@intelliot intelliot changed the title Add XLS-20 spec (fix #86) Add XLS-20 spec: Mar 20, 2023
Copy link
Contributor

@Silkjaer Silkjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need it added to the standards.toml and it's ready to merge.

XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
XLS-20/README.md Outdated Show resolved Hide resolved
@shawnxie999
Copy link
Collaborator Author

@intelliot this is ready to merge

@Silkjaer Silkjaer merged commit 1841528 into XRPLF:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0020 XLS-20d Non-Fungible Token Support (native)
4 participants