Feature/update clang format 16 #908

godexsoft · 2023-10-09T15:00:01Z

Test clang-format-16 on CI

src/etl/impl/AsyncData.h

kuznetsss

Code looks really good, just a few questions

src/data/cassandra/impl/Cluster.cpp

godexsoft added the on hold For issues that currently wait on other issues label Oct 9, 2023

godexsoft added this to the 2.1 milestone Oct 10, 2023

godexsoft added 10 commits October 19, 2023 01:56

Update pre-commit hook requirement for clang-format 16

52f47ac

Adjust clang-format settings and reformat code

d8ea941

Update contributing clang-format version

24d0cbb

Update github action to use clang-format 16

1383397

Try fix ci err

7b51689

Reformat codebase with new rules

53eb86d

Add rules to clang-format

12a1b1b

Try install with sudo

bda820f

Try use tee for appending under root

01b7a27

Use clang-format-16 bin

939fd93

godexsoft force-pushed the feature/update_clang_format_16 branch from 41b9fe9 to 939fd93 Compare October 19, 2023 01:12

godexsoft requested review from kuznetsss and cindyyan317 October 19, 2023 01:12

godexsoft commented Oct 19, 2023

View reviewed changes

src/etl/impl/AsyncData.h Outdated Show resolved Hide resolved

Fix strange formatting

280011c

kuznetsss reviewed Oct 19, 2023

View reviewed changes

src/data/cassandra/impl/Cluster.cpp Outdated Show resolved Hide resolved

src/data/cassandra/impl/Cluster.cpp Show resolved Hide resolved

Update brace style to WebKit

20460cb

cindyyan317 approved these changes Oct 19, 2023

View reviewed changes

kuznetsss approved these changes Oct 19, 2023

View reviewed changes

godexsoft marked this pull request as ready for review October 19, 2023 15:53

godexsoft merged commit 1aab2b9 into XRPLF:develop Oct 19, 2023
4 checks passed

Provide feedback