Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terNO_LINE and terNO_RIPPLE show incorrect explanations #2546

Closed
mvadari opened this issue Apr 15, 2024 · 2 comments
Closed

terNO_LINE and terNO_RIPPLE show incorrect explanations #2546

mvadari opened this issue Apr 15, 2024 · 2 comments
Labels
bug Typo or other small documentation error content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts

Comments

@mvadari
Copy link
Contributor

mvadari commented Apr 15, 2024

Page: https://xrpl.org/docs/references/protocol/transactions/transaction-results/ter-codes/#ter-codes

Both terNO_LINE and terNO_RIPPLE have this explanation:

Used internally only. This code should never be returned.

This is an incorrect explanation.
@mDuo13
Copy link
Collaborator

mDuo13 commented Apr 15, 2024 •
edited
Loading

I believe that the tec versions of these codes is normal but the ter version is not normally returned. A search of the rippled source implies this might be correct, but the total code path is unclear.

@mvadari
Copy link
Contributor Author

mvadari commented Apr 16, 2024 •
edited
Loading

I appear to have incorrectly extrapolated from one to the other - that does seem to be true for terNO_LINE, but not terNO_RIPPLE, which does seem to have legitimate code paths.
Search link: https://github.com/search?q=repo%3AXRPLF%2Frippled+terNO_RIPPLE&type=code

@mDuo13 mDuo13 added bug Typo or other small documentation error content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts labels Jul 8, 2024
@mDuo13 mDuo13 mentioned this issue Jul 8, 2024
Open
@mDuo13 mDuo13 closed this as completed in 9cbca12 Jul 11, 2024
mDuo13 added a commit that referenced this issue Jul 11, 2024
@mDuo13
Merge pull request #2668 from XRPLF/fix_terNo_RIPPLE
03bf86e 
Update terNO_RIPPLE description (Fixes #2546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Typo or other small documentation error content updates Updating, cleaning up, or rewriting existing content for better usability or new contexts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mDuo13 @mvadari