Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of SpanNameFormatter from interface to function #185

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

XSAM
Copy link
Owner

@XSAM XSAM commented Sep 14, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (4dbdf2f) 80.5% compared to head (ba2505c) 80.5%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #185   +/-   ##
=====================================
  Coverage   80.5%   80.5%           
=====================================
  Files         13      13           
  Lines        716     716           
=====================================
  Hits         577     577           
  Misses       115     115           
  Partials      24      24           
Files Changed Coverage Δ
config.go 88.8% <100.0%> (ø)
utils.go 95.0% <100.0%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XSAM XSAM merged commit 5b3eed6 into main Sep 14, 2023
21 checks passed
@XSAM XSAM deleted the span-name-formatter branch September 14, 2023 22:34
@XSAM XSAM mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant