fix(dns): avoid early return when dns query refused (#2878)

* avoid early return when dns query refused * address reviews
XTLS · Jan 2, 2024 · 60f7a03 · 60f7a03
1 parent 44bb830
commit 60f7a03
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/dns/dns.go b/app/dns/dns.go
@@ -215,7 +215,8 @@ func (s *DNS) LookupIP(domain string, option dns.IPOption) ([]net.IP, error) {
 			newError("failed to lookup ip for domain ", domain, " at server ", client.Name()).Base(err).WriteToLog()
 			errs = append(errs, err)
 		}
-		if err != context.Canceled && err != context.DeadlineExceeded && err != errExpectedIPNonMatch && err != dns.ErrEmptyResponse {
+		// 5 for RcodeRefused in miekg/dns, hardcode to reduce binary size
+		if err != context.Canceled && err != context.DeadlineExceeded && err != errExpectedIPNonMatch && err != dns.ErrEmptyResponse && dns.RCodeFromError(err) != 5 {
 			return nil, err
 		}
 	}