fix(transport): correctly release UDS locker file #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPRX
reviewed
Jul 21, 2023
| return nil, err | ||
| } | ||
| ctx = context.WithValue(ctx, address, locker) | ||
| // combine listener and unix domain socket locker | ||
| defer func(locker *FileLocker) { |
yin1999
commented
Jul 22, 2023
Comment on lines
-61
to
-77
| if s := strings.Split(address, ","); len(s) == 2 { | ||
| address = s[0] | ||
| perm, perr := strconv.ParseUint(s[1], 8, 32) | ||
| if perr != nil { | ||
| return nil, newError("failed to parse permission: " + s[1]).Base(perr) | ||
| } | ||
|
|
||
| defer func(file string, permission os.FileMode) { | ||
| if err == nil { | ||
| cerr := os.Chmod(address, permission) | ||
| if cerr != nil { | ||
| err = newError("failed to set permission for " + file).Base(cerr) | ||
| } | ||
| } | ||
| }(address, os.FileMode(perm)) | ||
| } | ||
|
|
There was a problem hiding this comment.
将逻辑移至常规 UDS 下，抽象 UDS 没有文件系统的权限概念。
|
感谢 PR，目测没有明显问题， |
yuhan6665
pushed a commit
that referenced
this pull request
Aug 26, 2023
* fix(transport): correctly release UDS locker file * use callback function to do some jobs after create listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unix domain socket locker file would not be released after closing listener.
That's because the context value set by the child cannot be obtained by the parent. And the current logic is a bit complex, we have to add the logic to release locker file everywhere we have used normal unix domain socket.