-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix buffer.UDP destination override #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
感谢 PR, |
我看了一下代码,包括 fakedns 在内的多个 sniffer 同时存在时,resComp.ProtocolForDomainResult() 会不会不是 "fakedns"? |
如果 fakedns+others (或者 fakedns 错失后使用其他 sniffer 补救的行为)的功能正常运作,这是有可能的。 |
我对这部分代码不熟悉,不过我觉得可以相信你的代码,让我们先把它合并,发一个 v1.8.4 让大家测试看看有没有引入新的问题 |
感谢 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous "fix" only works for FakeDNS (QUIC sniffer not working) and breaks NAT type.
To always send IP to proxy server for UDP, you may want to implement
domainStrategy
for outbound.