preserve exact header casing when using httpupgrade #3427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmray
commented
Jun 5, 2024
| } |
| First bool | ||
| } | ||
|
|
||
| func (c *ConnRF) Read(b []byte) (int, error) { | ||
| if c.First { | ||
| c.First = false | ||
| // TODO The bufio usage here is unreliable | ||
| resp, err := http.ReadResponse(bufio.NewReader(c.Conn), c.Req) // nolint:bodyclose | ||
| resp, err := http.ReadResponse(bufio.NewReader(c.Conn), nil) // nolint:bodyclose |
There was a problem hiding this comment.
"If nil, a GET request is assumed."
|
Thanks for your quick pr! I think it is better to keep the original logic unless user has a custom header setting |
|
done. i feel that this adds complexity to the code, and requires more tests because there are more branches. i understand that there is an attempt to avoid regressions though. |
|
it seems the tests on main branch are failing in a flaky+timeout way. i was debugging it but still could not figure out which test was broken 😅 |
|
This is annoying, may need to do a binary search to find the culprit.. |
|
|
|
speculative fix: #3428 |
|
I don't think we need to reduce code readability for a useless request |
|
I will write a simpler implementation later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3426