splithttp: Add support for H2C and http/1.1 ALPN on server #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users that encounter protocol version issues will likely try to set the ALPN explicitly. In that case we should simply grant their wish, because the intent is obvious.
mmmray
changed the title
|
Thanks! Looks good to me! |
|
几天前看了下代码才明白为啥客户端不好处理 ALPN，原来要先确定用 h1 还是 h2 再给它 TLS， |
|
@RPRX the issue is really specific to uTLS. When a regular The upgrade method, I couldn't find, but I think I tried all the APIs ("next protocol" callback in net/http, etc), didn't work. Maybe this problem needs fresh eyes. |
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #3464
H2C support is required so that fallbacks can work with splithttp at all. fallback with
path-based routing still doesn't work.