Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker.yml: Set latest to auto to tag release version #3581

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mayampi01
Copy link
Contributor

No description provided.

@mmmray
Copy link
Collaborator

mmmray commented Jul 22, 2024

what does this do? I see no missing tags here: https://github.com/xtls/Xray-core/pkgs/container/xray-core

@mayampi01
Copy link
Contributor Author

when latest=true, the 'latest' tag tags to latest commit (such as sha-c27d652).
when latest=auto, the 'latest' tag tags to latest release (such as 1.8.21).

@mayampi01
Copy link
Contributor Author

And latest=auto is the default mode, because the latest release fits for public consumption, not the latest commit.
https://github.com/docker/metadata-action?tab=readme-ov-file#latest-tag

@mmmray
Copy link
Collaborator

mmmray commented Jul 22, 2024

it's reasonable, thanks. in my opinion, if you want stability you should really pin the version in your docker-compose

@mmmray mmmray merged commit 36f427f into XTLS:main Jul 22, 2024
3 checks passed
@mayampi01 mayampi01 deleted the patch-2 branch July 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants