-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add new Get Inbound User #3644
Conversation
I keep hearing people talking about how shit mountain v2ray code is. So as I worked on this area, I'd share a bit of my opinion. |
Part of the problem lies in the documentation. As a rather complex part, its doc is quite brief, with usage methods ranging from api sub commands to grpcurl to directly calling the core func( |
True it could be an issue of documentation. |
关于这个 PR: 关于 API: ./grpcurl.exe -plaintext -d '{"tag": "ssin", "email": "[email protected]"}' 127.0.0.1:10085 xray
.app.proxyman.command.HandlerService.GetInboundUser 得到的是: {
"user": {
"email": "[email protected]",
"account": {
"type": "xray.proxy.shadowsocks.Account",
"value": "CgMxMTEQBg=="
}
}
} 然后这个 account 就不知道怎么用 grpcurl 解开了。 |
@vrnobody 感谢 review 这几个想法很有道理 我随后研究下 |
如果不急的话这样的修改放 v1.9 吧,我们有望这个月内结束 v1.8,也快了就 SplitHTTP 的几个 PR 发个版,然后再发个版本修 bug |
@RPRX 就是说下个月Switch咯() |
v1.9 的主题是 VLESS encryption 和 Vision seed,然后在维护过程中应该还会加个 Tun inbound、优化下 Xray 的转发性能等,尤其是 UDP 和 WireGuard,虽然后者用得很少, |
咋都在想 Switch,我是觉得它和 PLUX 更多地算是一种增强,而随着 SplitHTTP 和 H3 和 multiplex control 的加入以及 v1.9 的 VLESS encryption 和 Vision seed, 至于其它实现是否跟进,I don't care,就算跟进了也不能保证持续更新,直接用 Xray 不就行了?要不给你们加一套 Clash API? |
加 Clash API 当然是说着玩的忘加删除线了,不过如果有人 PR 的话大概率会合并。“啥时候出个只有 VLESS 的”,我是觉得再用 Go 写个 VLESS-core 过于重复,两年没写 Rust 了,今天看了下还是没 Chrome 指纹,看看 refraction-networking/utls#103 (comment) |
This api costs much less than get inbound user, could be useful in some case
This is related to #2865 what I consider a proper way to implement get API
CC @vrnobody