Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor file & format array to an struct array #3687

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

jadeydi
Copy link
Contributor

@jadeydi jadeydi commented Aug 16, 2024

No description provided.

@jadeydi
Copy link
Contributor Author

jadeydi commented Aug 16, 2024

目的主要是方便阅读代码,如果是把 file 跟 format 放到两个数组,做为两个参数,通常不会认为这两者有关联,会增加理解的成本

@RPRX RPRX requested a review from yuhan6665 August 16, 2024 02:52
@RPRX
Copy link
Member

RPRX commented Aug 16, 2024

@yuhan6665 你 approve 后,我想个合适的标题

Copy link
Member

@yuhan6665 yuhan6665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RPRX RPRX merged commit 1562e1f into XTLS:main Aug 16, 2024
36 checks passed
zxspirit pushed a commit to zxspirit/Xray-core that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants