-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freedom: Fix PacketReader/PacketWriter type assertion #3734
Conversation
感谢佬 |
经测试这在 v2rayNG 上不工作,请 revert 掉吧。 |
Xray-core/proxy/freedom/freedom.go Line 385 in 6baad79
|
OK, I reverted the PR and filed an issue for now, just so it's documented: #3750 |
I think under current API structure the fix has to to be done on AndroidLibXrayLite side. Unless new API is added, no further fix can be going on here. I raised a PR for AndroidLibXrayLite. |
…)" This reverts commit 815a959.
通过
UseAlternativeSystemDialer
或RegisterDialerController
使用自定义 dialer 替换DefaultSystemDialer
后,自定义 dialer 返回的net.Conn
没有保证可以断言为*PacketConnWrapper
。以 v2rayNG(AndroidLibXrayLite)为例,其自定义 dialer 返回的
net.Conn
可以被断言为*net.UDPConn
但不能被断言为*PacketConnWrapper
,NewPacketReader
和NewPacketWriter
断言失败,PacketReader
和PacketWriter
不会被使用。上下文:#3711 (comment) ,需要由真正的 v2rayNG 用户测试这在 v2rayNG 上是否有效。