Config: Remove some legacy fields from V2Ray 3.x era #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPRX
changed the title
RPRX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dug out two undocumented config items from the code, and the archaeological analysis told they're from V2Ray-core 3.x (around 2018), and were brought into Xray-core since day one.
The removed config items are:
featuresunder VMess inbound config: This config item only contains a detour config which act as the same asdetourunder VMess inbound config, and should be deprecated as only thedetouris documented.domainOverrideunder inbound config: This is the one really deprecated as the sniffing config was introduced in V2Ray 3.x anddomainOverridegot quickly deprecated. When this is existed in the config it just turn on the sniffing config now, but it won't turn on QUIC sniffer and FakeDNS sniffer.Why they were here was just because in V2Ray-core each version of config format can be used for one main version, and can be used with the next main version for compatibility and migration, but V2Ray-core 4.x lasts unpredictably long and Xray-core inherited the config format from V2Ray-core 4.x, these old config codes just sitting there and being forgotten, like #2841 and #3163 and #3769.
Luckily there seems no more hidden undocumented configs that were deprecated and should be removed now. Those 3.x config items seems no need to be compatible for now in 2024 as 4.x format has spread for a very long time.