Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New device types #24

Closed
davidt94 opened this issue May 29, 2022 · 17 comments
Closed

New device types #24

davidt94 opened this issue May 29, 2022 · 17 comments
Labels
enhancement New feature or request more information needed More information needed

Comments

@davidt94
Copy link

davidt94 commented May 29, 2022

Hello, Many thanks for this integration its fantastic. I have the following Unknown device types. Would be great if you could add those if possible. (I dont think the last 3 will be of much use)

Auxiliary Pendant

2022-05-29 20:46:33.335795 WARNING qolsys_panel: sensor of unknown type: {'id': '101-6464', 'type': 'Auxiliary Pendant', 'name': 'Panic Alarm', 'group': 'fixedintrusion', 'status': 'Closed', 'state': '0', 'zone_id': 28, 'zone_physical_type': 11, 'zone_alarm_type': 0, 'zone_type': 21, 'partition_id': 0}

This is just a standard door sensor that has an Auxiliary input I have a Panic Alarm wired into the input._ https://www.visonic.com/Products/PowerG-Wireless-Property-Protection/mc-302e-pg2

Siren

2022-05-29 20:46:33.340648 WARNING qolsys_panel: sensor of unknown type: {'id': '410-4121', 'type': 'Siren', 'name': 'Front Siren', 'group': 'Siren', 'status': 'Closed', 'state': '0', 'zone_id': 29, 'zone_physical_type': 1, 'zone_alarm_type': 3, 'zone_type': 14, 'partition_id': 0}

Standard outdoor Siren https://www.visonic.com/Products/PowerG-Wireless-Property-Protection/sr-740-pg2

Keypad

2022-05-29 20:46:33.349919 WARNING qolsys_panel: sensor of unknown type: {'id': '374-5234', 'type': 'Keypad', 'name': 'Upstairs Keypad', 'group': 'fixedintrusion', 'status': 'Closed', 'state': '0', 'zone_id': 31, 'zone_physical_type': 4, 'zone_alarm_type': 0, 'zone_type': 104, 'partition_id': 0}

Keypad https://www.visonic.com/Products/PowerG-Wireless-Property-Protection/kp-160-pg2

KeyFob

2022-05-29 20:46:33.354810 WARNING qolsys_panel: sensor of unknown type: {'id': '301-2914', 'type': 'KeyFob', 'name': "Keyfob 1", 'group': 'mobileintrusion', 'status': 'Closed', 'state': '0', 'zone_id': 32, 'zone_physical_type': 3, 'zone_alarm_type': 0, 'zone_type': 102, 'partition_id': 0}

Keyfob https://www.visonic.com/Products/PowerG-Wireless-Property-Protection/kf-235-pg2

Many thanks!!

@XaF
Copy link
Owner

XaF commented Jun 3, 2022

Would you be able to provide the INFO message for those too ?
As well as any status update you can observe when acting with them ?

Thanks!

@XaF XaF added enhancement New feature or request more information needed More information needed labels Jun 3, 2022
@davidt94
Copy link
Author

davidt94 commented Jun 4, 2022

Yes no problem. This may be a stupid question but where do I find this info message? Thank you!

@XaF
Copy link
Owner

XaF commented Jun 4, 2022

So you'll need to enable debug mode to see everything and not just warnings, and you should see all the interactions with your panel in the appdaemon logs. From there you should see that when the integration connects to your panel it sends an INFO request and receives a bunch of data with the panel partition and all the sensors. It's a slightly different message than a zone update, so I want to know what it contains! :)

@Pablo1
Copy link

Pablo1 commented Nov 9, 2022

@XaF - I also have multiple sensors that are not being recognized. I'm not sure if you're still actively developing the integration but I would be happy to either submit a pull request or provide you with the info you need to add the sensor types.

@XaF
Copy link
Owner

XaF commented Nov 9, 2022

Hello @Pablo1 - I am indeed still maintaining this integration. I have been working - for a bit - on writing tests for it, since I wanna make sure that adding new features or options does not break existing features of it (and adding new features also makes it more complicated to do comprehensive testing without actual tests).

That being said, if you have information for sensors, I'll happily take this information, and any suggestion about what should be their representation in Home Assistant. I, of course, can only support things that are natively supported by the Control4 interface of the panel! Thanks!

@Pablo1
Copy link

Pablo1 commented Nov 9, 2022

The three sensor types that I've noticed are missing are

Auxiliary Pendant
Key Fob
Keypad

Not sure what they should map to. I use auxiliary pendant for a custom trouble sensor (just a door sensor). Keypad is an IQ Remote Keypad.

If you point me to the right spot in the code I can make sure to add some debugging and capture the exact json for you.

@XaF
Copy link
Owner

XaF commented Nov 9, 2022

With debug enabled for the AppDaemon app, you should already have the right debugging enabled. You should be able to see in the logs (of AppDaemon) any message that is being ignored by qolsysgw. It would be good to know what are the Control4 messages that the panel sends for those elements, as to identify if it makes sense to map them in Home Assistant, and what to map them to, and what actions would be reported to Home Assistant for those!

@Pablo1
Copy link

Pablo1 commented Nov 10, 2022 via email

@XaF
Copy link
Owner

XaF commented Nov 10, 2022

Are you able to see other messages for those with different status, corresponding to when you press the button, or a delay?

Are you able to share your ZONE_INFO message too, which should contain those two?

Thanks!

@Pablo1
Copy link

Pablo1 commented Nov 11, 2022

I assume you mean "INFO"? If so here they are:

{"id":"305-7957","type":"KeyFob","name":"Key Fob","group":"mobileintrusion","status":"Closed","state":"0","zone_id":13,"zone_physical_type":3,"zone_alarm_type":0,"zone_type":102,"partition_id":0}

{"id":"101-5037","type":"Auxiliary Pendant","name":"Combustible Gas Trouble","group":"fixedmedical","status":"Closed","state":"0","zone_id":38,"zone_physical_type":1,"zone_alarm_type":0,"zone_type":21,"partition_id":0}

There's also a remote keypad which often shows up as Unknown as well:

{"id":"IQR1","type":"Keypad","name":"IQ Remote 1","group":"fixedintrusion","status":"Closed","state":"0","zone_id":48,"zone_physical_type":4,"zone_alarm_type":0,"zone_type":104,"partition_id":0}

@XaF
Copy link
Owner

XaF commented Nov 11, 2022

Does the keypad have any updates when you use it?

@Pablo1
Copy link

Pablo1 commented Nov 12, 2022

Unfortunately it does not appear to have any updates. Even if I arm/disarm from the IQ Remote Keypad it doesn't seem to make a distinction between the IQ Remote and the main keypad.

@XaF
Copy link
Owner

XaF commented Nov 12, 2022

Yeah ok, I believe it's just indicating that the keypad exists but there's no real interest in having it appear in Home Assistant then! I might just end up ignoring it but actively (so it won't show messages about "unknown" sensor in the logs)

@Pablo1
Copy link

Pablo1 commented Nov 12, 2022

That seems reasonable. Thank you so much for creating this integration. The previous one had some pretty serious bugs that I created a PR for but it never got merged. Please let me know if I can help.

@XaF
Copy link
Owner

XaF commented Nov 12, 2022

I'm holding on new features and additions until I have enough testing of the integration, as I want to make sure anything new that end up being added does not break what currently works. So that might take a little bit still, but it's on the way! (I'm currently working on that in a side-branch that you can see there)

@Pablo1
Copy link

Pablo1 commented Nov 13, 2022

Thank you. Your hard work is definitely appreciated. Being able to use all of the Qolsys sensors as part of HA is awesome !

@XaF
Copy link
Owner

XaF commented Dec 20, 2022

Created issues for each new sensor type, so I can aggregate all the information I need for each in specific places:

Going to close this issue as I grabbed all the information I needed that was available here!

@XaF XaF closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request more information needed More information needed
Projects
None yet
Development

No branches or pull requests

3 participants