Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [feature] disable by default entities that do not update #72

Merged

Conversation

XaF
Copy link
Owner

@XaF XaF commented Jan 7, 2023

Entities such as 'bluetooth' devices are declared as sensors but do not seem to receive updates from the panel after that. We can thus simply disable those by default, allowing people that want to see them to enable them on a sensor-by-sensor basis, or even enable all of them thanks to a new configuration option
enable_static_sensors_by_default that can be set to true.

Fixes #67

@XaF XaF added the enhancement New feature or request label Jan 7, 2023
Entities such as 'bluetooth' devices are declared as sensors but do
not seem to receive updates from the panel after that. We can thus
simply disable those by default, allowing people that want to see
them to enable them on a sensor-by-sensor basis, or even enable
all of them thanks to a new configuration option
`enable_static_sensors_by_default` that can be set to `true`.
@XaF XaF force-pushed the xaf/use_enabled_by_default_to_disable_sensors_without_updates branch from 938f92b to a67d450 Compare January 7, 2023 20:31
@github-actions
Copy link

github-actions bot commented Jan 7, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py238797%164, 212, 215, 333, 384, 462, 540
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%63–64, 66, 70, 75, 90–102, 112, 120, 146
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1812288%51–72, 116, 120, 126, 155, 159, 166, 183, 187
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py47491%11, 14, 20–21
TOTAL152514790% 

Tests Skipped Failures Errors Time
114 0 💤 0 ❌ 0 🔥 29.369s ⏱️

@XaF XaF merged commit 02d54b2 into main Jan 7, 2023
@XaF XaF deleted the xaf/use_enabled_by_default_to_disable_sensors_without_updates branch January 7, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use enabled_by_default to false in the MQTT payloads for entities that do not update
1 participant