Update v61 migration to handle duplicate job names before unique cons…

…traint (MarquezProject#2464)

Signed-off-by: Michael Collado <[email protected]>
Signed-off-by: Xavier-Cliquennois <[email protected]>

api/src/main/resources/marquez/db/migration/V61__unique_job_fqn_index.sql

@@ -1,10 +1,45 @@
+WITH fqn AS (
+  SELECT f.uuid,
+         f.job_fqn AS name,
+         f.namespace_name,
+         j.name    AS simple_name,
+         j.parent_job_uuid,
+         f.parent_job_name::text,
+         j.symlink_target_uuid
+  FROM jobs_fqn f,
+       jobs j
+  WHERE j.uuid = f.uuid
+)
 UPDATE jobs SET symlink_target_uuid=q.target_uuid
 FROM (
          SELECT j.uuid, j.namespace_name, j.name, j.simple_name, jv.uuid AS target_uuid, jv.simple_name
-         FROM jobs_view j INNER JOIN jobs_view jv ON j.namespace_name=jv.namespace_name AND j.name=jv.name AND j.simple_name != jv.simple_name
+         FROM fqn j
+         INNER JOIN fqn jv ON j.namespace_name=jv.namespace_name AND j.name=jv.name AND j.simple_name != jv.simple_name
          WHERE j.symlink_target_uuid IS NULL
-           AND jv.symlink_target_uuid IS NULL
-           AND j.parent_job_uuid IS NULL) q
+         AND jv.symlink_target_uuid IS NULL
+         AND j.parent_job_uuid IS NULL) q
+WHERE jobs.uuid=q.uuid;
+
+WITH fqn AS (
+  SELECT f.uuid,
+         f.job_fqn AS name,
+         f.namespace_name,
+         j.name    AS simple_name,
+         j.parent_job_uuid,
+         f.parent_job_name::text,
+         j.symlink_target_uuid,
+         j.created_at
+  FROM jobs_fqn f,
+       jobs j
+  WHERE j.uuid = f.uuid
+)
+UPDATE jobs SET name=(q.simple_name || '_' || q.row)
+FROM (
+  SELECT j.uuid, j.namespace_name, j.name, j.simple_name, jv.uuid AS target_uuid,
+         row_number() over (PARTITION BY j.namespace_name, j.name ORDER BY j.created_at) AS row
+  FROM fqn j
+  INNER JOIN fqn jv ON j.namespace_name=jv.namespace_name AND j.name=jv.name AND j.symlink_target_uuid=jv.uuid
+) q
 WHERE jobs.uuid=q.uuid;
 
 ALTER TABLE jobs RENAME COLUMN name TO simple_name;
@@ -30,4 +65,4 @@ WHERE jobs.uuid=f.uuid;
 ALTER TABLE jobs ALTER COLUMN name SET NOT NULL;
 
 ALTER TABLE jobs DROP CONSTRAINT unique_jobs_namespace_uuid_name_parent;
-ALTER TABLE jobs ADD CONSTRAINT unique_jobs_namespace_uuid_name_parent UNIQUE (namespace_uuid, name);
+ALTER TABLE jobs ADD CONSTRAINT unique_jobs_namespace_uuid_name_parent UNIQUE (namespace_uuid, name);