Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove split CCL #644

Merged
merged 21 commits into from
Sep 18, 2024
Merged

Remove split CCL #644

merged 21 commits into from
Sep 18, 2024

Conversation

WeiyiVirtonomy
Copy link
Collaborator

@WeiyiVirtonomy WeiyiVirtonomy commented Aug 23, 2024

The split cell linked list is replaced by a function called particle_for_split, where the cells are accessed by a stride of 3 in the indices.

TODO:
Add sequential version
Add unit test

@WeiyiVirtonomy
Copy link
Collaborator Author

I added the sequential version and unit tests

@WeiyiVirtonomy
Copy link
Collaborator Author

I had some misunderstanding about the method, will fix it tomorrow

@WeiyiVirtonomy WeiyiVirtonomy marked this pull request as ready for review September 12, 2024 12:17
@WeiyiVirtonomy
Copy link
Collaborator Author

I think this PR is ready for review now

@WeiyiVirtonomy
Copy link
Collaborator Author

WeiyiVirtonomy commented Sep 12, 2024

@DongWuTUM The computational time of damping is too long. I ran the same simulation without and with damping, the previous one took 104s and the later one took 199s, nearly a 90% increment.
The one with block_2d loop + mod is close to the two 1D loop one. For some reason, the 2D parallel algorithm is much slower than the 1D parallel of split cell list vector

FYI, for test_3d_arch, the computational time on my machine is:
Old method: without damping 26.1719s, with damping 37.9359s, damping time 11.764s
New method: without damping 23,214s, with damping 47.5902s, damping time 24.3762s

The damping computational time of the new method is twice more than that of the old method

@Xiangyu-Hu
Copy link
Owner

@WeiyiVirtonomy I guess that there is something wrong.

@Xiangyu-Hu
Copy link
Owner

@WeiyiVirtonomy As the master has been updated, the conflicts must be resolved first for the merge. i also noticed that there are some function is base mesh have repeating implementation, please also clean these repeating if there is any.

@WeiyiVirtonomy
Copy link
Collaborator Author

@WeiyiVirtonomy As the master has been updated, the conflicts must be resolved first for the merge. i also noticed that there are some function is base mesh have repeating implementation, please also clean these repeating if there is any.

Merge conflict is now solved

@Xiangyu-Hu Xiangyu-Hu merged commit 8b33bac into master Sep 18, 2024
7 checks passed
@Xiangyu-Hu Xiangyu-Hu deleted the wip/kong/split_dynamics_restructure branch September 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants