This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
feat(shell): support resolve IP address in dsn/utility #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
changed the title
utils:support resolve IP address in ddl_client
utils: support resolve IP address in ddl_client
Nov 11, 2019
Smityz
changed the title
utils: support resolve IP address in ddl_client
BREAKING CHANGE: the return value of a series of hostname_from_ip has changed into bool, the result is returned by the pointer now
Nov 11, 2019
Smityz
changed the title
BREAKING CHANGE: the return value of a series of hostname_from_ip has changed into bool, the result is returned by the pointer now
feat(shell):add resolve functions in some commands
Nov 12, 2019
Smityz
changed the title
feat(shell):add resolve functions in some commands
feat(shell): support resolve IP address in ddl_client
Nov 12, 2019
acelyc111
reviewed
Nov 13, 2019
src/dist/replication/test/replica_test/unit_test/CMakeLists.txt
Outdated
Show resolved
Hide resolved
acelyc111
reviewed
Nov 13, 2019
acelyc111
reviewed
Nov 13, 2019
neverchanje
reviewed
Nov 15, 2019
Smityz
changed the title
feat(shell): support resolve IP address in ddl_client
feat(shell): support resolve IP address in dsn/utility
Nov 18, 2019
acelyc111
reviewed
Nov 18, 2019
acelyc111
previously approved these changes
Nov 18, 2019
vagetablechicken
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
acelyc111
approved these changes
Nov 19, 2019
neverchanje
reviewed
Nov 19, 2019
// valid a.b.c.d -> return TRUE && hostname_result=hostname | invalid a.b.c.d:port1 -> return | ||
// FALSE | ||
// && hostname_result=a.b.c.d | ||
bool hostname_from_ip(const char *ip, std::string *hostname_result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么不直接写一个新文件 hostname_utils.h/hostname_utils.cpp 啊,utils.h 里的东西太杂了,很难管理
namespace dsn { | ||
namespace replication { | ||
|
||
TEST(ip_to_hostname, localhost) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上,建议改名 hostname_utils_test.cpp
Smityz
added a commit
to Smityz/rdsn
that referenced
this pull request
Nov 21, 2019
feat(shell): support resolve IP address in dsn/utility (XiaoMi#337)
acelyc111
pushed a commit
that referenced
this pull request
Dec 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
I add a unit test in
/src/core/tests/hostname.cpp
Code changes
Side effects
Related changes