Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: fix memory leak in meta test #449

Merged
merged 4 commits into from
Apr 27, 2020
Merged

fix: fix memory leak in meta test #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a21486f
memory leak in meta test
Apr 27, 2020
c82a60d
Merge branch 'master' into memory-leak-in-meta-test
Apr 27, 2020
b1d9040
fix
Apr 27, 2020
015dc05
Merge branch 'memory-leak-in-meta-test' of github.com:levy5307/rdsn i…
Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/dist/replication/test/meta_test/unit_test/server_state_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ void meta_service_test_app::app_envs_basic_test()
request.__set_keys(keys);
request.__set_values(values);

dsn::message_ex *binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::message_ptr binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::marshall(binary_req, request);
dsn::message_ex *recv_msg = create_corresponding_receive(binary_req);
app_env_rpc rpc(recv_msg); // don't need reply
Expand All @@ -102,7 +102,7 @@ void meta_service_test_app::app_envs_basic_test()
request.__set_op(app_env_operation::type::APP_ENV_OP_DEL);
request.__set_keys(del_keys);

dsn::message_ex *binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::message_ptr binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::marshall(binary_req, request);
dsn::message_ex *recv_msg = create_corresponding_receive(binary_req);
app_env_rpc rpc(recv_msg); // don't need reply
Expand Down Expand Up @@ -131,7 +131,7 @@ void meta_service_test_app::app_envs_basic_test()
request.__set_op(app_env_operation::type::APP_ENV_OP_CLEAR);
request.__set_clear_prefix(clear_prefix);

dsn::message_ex *binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::message_ptr binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::marshall(binary_req, request);
dsn::message_ex *recv_msg = create_corresponding_receive(binary_req);
app_env_rpc rpc(recv_msg); // don't need reply
Expand Down Expand Up @@ -163,7 +163,7 @@ void meta_service_test_app::app_envs_basic_test()
request.__set_op(app_env_operation::type::APP_ENV_OP_CLEAR);
request.__set_clear_prefix("");

dsn::message_ex *binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::message_ptr binary_req = dsn::message_ex::create_request(RPC_CM_UPDATE_APP_ENV);
dsn::marshall(binary_req, request);
dsn::message_ex *recv_msg = create_corresponding_receive(binary_req);
app_env_rpc rpc(recv_msg); // don't need reply
Expand Down
5 changes: 4 additions & 1 deletion src/dist/replication/test/meta_test/unit_test/update_configuration_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ class fake_sender_meta_service : public dsn::replication::meta_service
public:
fake_sender_meta_service(meta_service_test_app *app) : meta_service(), _app(app) {}

virtual void reply_message(dsn::message_ex *request, dsn::message_ex *response) override {}
virtual void reply_message(dsn::message_ex *request, dsn::message_ex *response) override
{
destroy_message(response);
}
virtual void send_message(const dsn::rpc_address &target, dsn::message_ex *request) override
{
// we expect this is a configuration_update_request proposal
Expand Down