This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk-load): meta server send bulk load request #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
changed the title
levy5307
reviewed
May 11, 2020
levy5307
reviewed
May 11, 2020
levy5307
reviewed
May 11, 2020
levy5307
reviewed
May 11, 2020
levy5307
reviewed
May 11, 2020
acelyc111
reviewed
May 12, 2020
| return; | ||
| } | ||
|
|
||
| broadcast_group_bulk_load(request); |
There was a problem hiding this comment.
Whether broadcast_group_bulk_load success or not doesn't influence response?
There was a problem hiding this comment.
- meta -> primary: send bulk _load_request
- primary -> secondary: send group_bulk_load_request (through broadcast_group_bulk_load)
- secondary -> primary : report bulk load state (in group_bulk_load_response)
- primary -> meta: report group bulk load states (in bulk_load_response)
meta receives bulk_load_response, get group bulk load states, if bulk load is not finished, meta will resend bulk _load_request to primary.
If broadcast_group_bulk_load failed, the states in response reported to meta may not fresh. However, it is ok, meta will resend request and finally get the states. Besides, broadcasting group bulk load is not a synchronous process, the states in response will not always be fresh.
acelyc111
reviewed
May 12, 2020
acelyc111
approved these changes
May 13, 2020
levy5307
approved these changes
May 13, 2020
hycdong
added a commit
to hycdong/rdsn
that referenced
this pull request
May 14, 2020
This was referenced May 28, 2020
This was referenced Jun 4, 2020
This was referenced Jun 15, 2020
Closed
Merged
This was referenced Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about meta server send bulk_load_request to replica server.
partition_bulk_loadon_bulk_loadwhen receive bulk_load_requestdo_bulk_load- not implemented in this pr )broadcast_group_bulk_load,report_bulk_load_states_to_meta- not implemented in this pr)on_partition_bulk_load_replywhen receive bulk_load_response, also not implemented in this pr.Whole bulk load process document can be found in official website: bulk_load_design