[Interchange] Reorders tile types and tiles to follow their Vivado index #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lavin <[email protected]>
Signed-off-by: Chris Lavin <[email protected]>
eddieh-xlnx
approved these changes
Aug 28, 2024
src/com/xilinx/rapidwright/interchange/DeviceResourcesWriter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: eddieh-xlnx <[email protected]> Signed-off-by: Chris Lavin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the export order of tiles (
tileList) and tile types (tileTypeList) in Interchange.devicefiles such that the order reflects the original Vivado-given index.Tiles: Each tile in a device is given a unique address or
INDEXthat is often computed byTOTAL_DEVICE_COLUMNS*TILE_ROW + TILE_COLUMN. This PR now orders the tiles in the device resources file according to this index.Tile Types: The Interchange has a Tile Type object, but Vivado annotates tile type information on the tile. Vivado uses a
TILE_TYPE_IDXto denote the order of the tile type. This is mostly alphabetical order except the 0-indexed entry is theNULLtype.The device verifier is also modified to verify that the tile orders match once the file is parsed. Since tile type indices are not declared in the interchange schema, the ordering is not verified.