Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize wheels #1646

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Reorganize wheels #1646

wants to merge 10 commits into from

Conversation

andrej
Copy link
Collaborator

@andrej andrej commented Jul 26, 2024

Towards pip install mlir-aie "just working", i.e. no need to mess with PATHs and the like afterwards.

  • Move mlir_aie/bin to <packagename>.data/scripts inside wheel.
    • This means during installation, pip install mlir-aie will put aiecc.py, aie-opt etc. into a directory that is already on the user's PATH.
  • Add mlir and mlir-python-utils as dependencies in the mlir-aie wheel.
    • This means users won't have to install these dependencies manually.

@andrej
Copy link
Collaborator Author

andrej commented Jul 26, 2024

I have new found respect for you @makslevental for dealing with the mess that is Python setuptools/distutils. Not very fun.

This might end up being kind of hard to make work. I have not seen any provisions in the wheel spec that would allow for installing shared libraries, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant