Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel Operations May Fail Depending on DeallocOp() Placement #660

Open
hunhoffe opened this issue Jul 10, 2024 · 2 comments
Open

Channel Operations May Fail Depending on DeallocOp() Placement #660

hunhoffe opened this issue Jul 10, 2024 · 2 comments

Comments

@hunhoffe
Copy link
Collaborator

hunhoffe commented Jul 10, 2024

This is part of my effort to write examples using channels in a variety of ways (#648).

I've been having some issues with getting worker-to-worker (core-to-core within a herd) data movement with channels to work. I managed to make it work, but the program is extremely brittle.

For instance, moving a deallocation sooner caused the program to work, where if I had my deallocations at the end, the output was all zeroes.

My code is found here: #697
The commit to move the dealloc ops that fixed the example is: 17162b1

@hunhoffe
Copy link
Collaborator Author

hunhoffe commented Aug 2, 2024

I did a redesign here, but it still does not work:
#697
The output data is all zeroes. However, the redesign definitely fixed a bug or two in the original design.

@hunhoffe hunhoffe changed the title Worker-to-Worker Channel Example Worker-to-Worker Channel Example is Brittle Aug 14, 2024
@hunhoffe hunhoffe changed the title Worker-to-Worker Channel Example is Brittle Channel Operations May Fail Depending on DeallocOp() Placement Aug 14, 2024
@hunhoffe
Copy link
Collaborator Author

hunhoffe commented Aug 14, 2024

I fixed the design, but I think the previous design should have been valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant