-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel example worker to worker fix, minor fixes for other examples #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunhoffe
changed the title
Worker to Worker Redesign
WIP: Worker to Worker Redesign and Debugging
Aug 2, 2024
hunhoffe
changed the title
WIP: Worker to Worker Redesign and Debugging
Channel example worker to worker redesign, some minor style + function fixes for other programming examples
Aug 10, 2024
hunhoffe
changed the title
Channel example worker to worker redesign, some minor style + function fixes for other programming examples
Channel example worker to worker redesign, minor fixes for other examples
Aug 10, 2024
hunhoffe
force-pushed
the
worker-to-worker-fix
branch
from
August 12, 2024 16:34
acfae60
to
1397ac3
Compare
hunhoffe
requested review from
fifield and
erwei-xilinx
and removed request for
jgmelber
August 12, 2024 17:05
hunhoffe
changed the title
Channel example worker to worker redesign, minor fixes for other examples
Channel example worker to worker fix, minor fixes for other examples
Aug 14, 2024
erwei-xilinx
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel example for worker to worker previously did not work. In addition to the lack of functionality, a known limitation of the old design was that it only worked for when an image was broken up into a 2x2 set of data tiles.
I decided to go through it and spend more time on checking the design, as well as relaxing that limitation. I did that, and I found another error besides, and fixed the example.
However, the example is still a little brittle so I created an issue to address this.