Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel example worker to worker fix, minor fixes for other examples #697

Merged
merged 18 commits into from
Aug 14, 2024

Conversation

hunhoffe
Copy link
Collaborator

@hunhoffe hunhoffe commented Aug 2, 2024

The channel example for worker to worker previously did not work. In addition to the lack of functionality, a known limitation of the old design was that it only worked for when an image was broken up into a 2x2 set of data tiles.

I decided to go through it and spend more time on checking the design, as well as relaxing that limitation. I did that, and I found another error besides, and fixed the example.

However, the example is still a little brittle so I created an issue to address this.

@hunhoffe hunhoffe changed the title Worker to Worker Redesign WIP: Worker to Worker Redesign and Debugging Aug 2, 2024
@hunhoffe hunhoffe changed the title WIP: Worker to Worker Redesign and Debugging Channel example worker to worker redesign, some minor style + function fixes for other programming examples Aug 10, 2024
@hunhoffe hunhoffe changed the title Channel example worker to worker redesign, some minor style + function fixes for other programming examples Channel example worker to worker redesign, minor fixes for other examples Aug 10, 2024
@hunhoffe hunhoffe marked this pull request as ready for review August 12, 2024 17:05
@hunhoffe hunhoffe requested review from fifield and erwei-xilinx and removed request for jgmelber August 12, 2024 17:05
@hunhoffe hunhoffe changed the title Channel example worker to worker redesign, minor fixes for other examples Channel example worker to worker fix, minor fixes for other examples Aug 14, 2024
@hunhoffe hunhoffe mentioned this pull request Aug 14, 2024
11 tasks
@hunhoffe hunhoffe merged commit 96a2969 into main Aug 14, 2024
11 checks passed
@hunhoffe hunhoffe deleted the worker-to-worker-fix branch August 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants