Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http.TimeoutHandler for rpc http server #469

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Mar 4, 2024

Proposed changes

The PR #363 only add parameter WriteTimeout for http server. But there are potential issues when timeout:

  • the connection is closed and server return empty reply
  • the request Context is not canceled

This PR set http.TimeoutHandler for http server in package rpc when timeout:

  • return with http code 503 and static body message: {"error":"http server timeout"}
  • the request Context is canceled

background information:

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

rpc/http.go Show resolved Hide resolved
@gzliudan gzliudan requested a review from liam-lai March 4, 2024 10:27
@gzliudan gzliudan merged commit 5223454 into XinFinOrg:dev-upgrade Mar 4, 2024
@liam-lai liam-lai mentioned this pull request Mar 4, 2024
19 tasks
@gzliudan gzliudan deleted the http-server-timeout branch March 7, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants