Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the performance of eth_getLogs #569

Closed
wants to merge 8 commits into from
Closed

Improve the performance of eth_getLogs #569

wants to merge 8 commits into from

Conversation

JukLee0ira
Copy link

@JukLee0ira JukLee0ira commented Jul 2, 2024 •
edited
Loading

Proposed changes

Continuation of PR #568

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement
  • Performance

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@JukLee0ira JukLee0ira force-pushed the addLogCache branch 20 times, most recently from 2cd90e3 to 4371013 Compare July 10, 2024 07:31
@JukLee0ira JukLee0ira marked this pull request as draft July 10, 2024 10:19
@gzliudan
Copy link
Collaborator

Please push these commits by the below order:

@gzliudan
Copy link
Collaborator

The type Backend interface miss SubscribePendingLogsEvent in file internal/ethapi/backend.go.

@gzliudan gzliudan changed the title add global block logs cache Improve the performance of eth_getLogs Jul 11, 2024
@JukLee0ira JukLee0ira force-pushed the addLogCache branch 5 times, most recently from 843da65 to c62fbcf Compare July 11, 2024 06:43
@JukLee0ira JukLee0ira marked this pull request as ready for review July 11, 2024 07:46
@JukLee0ira JukLee0ira force-pushed the addLogCache branch 2 times, most recently from 47d9a52 to eba3d73 Compare July 11, 2024 08:23
@JukLee0ira JukLee0ira force-pushed the addLogCache branch 2 times, most recently from 25ec343 to 97eb3bb Compare July 11, 2024 09:10
@gzliudan
Copy link
Collaborator

Please add ethereum#24949 before ethereum#25459

@JukLee0ira JukLee0ira mentioned this pull request Jul 15, 2024
Merged
20 tasks
@JukLee0ira JukLee0ira changed the title Improve the performance of eth_getLogs [WIP]Improve the performance of eth_getLogs Jul 18, 2024
@JukLee0ira JukLee0ira changed the title [WIP]Improve the performance of eth_getLogs Improve the performance of eth_getLogs Jul 22, 2024
@JukLee0ira JukLee0ira closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JukLee0ira @gzliudan