-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
precise wheel event for the html5 client #1797
Comments
Done in r18920, the html5 client will now trigger precise scroll events if the server has uinput enabled:
@maxmylyn: works for me, could be interesting for you guys. Do we need to map the macos scroll direction differently? (ie: is it somehow normalized the "right" way by some browsers) |
2018-04-20 18:20:27: maxmylyn commented
|
Not sure if that means that we're doing the right thing or that we need to invert the values on macos. Please clarify. |
2018-04-24 20:26:36: maxmylyn commented
|
Did you test horizontal scrolling with a non-macos OS to compare? (ideally ms windows) I only have horizontal buttons, no wheel on any of my test devices. Those events come up a individual clicks, and they're using the same button number (4 and 5) as what vertical scrolling is meant to use (with r19072 to get javascript console debug logging with "mouse" debug enabled):
So r19073 remaps those buttons to 8 / 9, since that's what xev sees without xpra - I'm not 100% sure that's right though. |
2018-06-06 18:48:48: maxmylyn commented
|
r19574 swaps left and right. Please confirm that this fixes things so that I can backport. |
2018-06-06 19:08:49: maxmylyn commented
|
2018-06-07 23:36:52: maxmylyn commented
|
@afarr: do you have a win32 and / or macos client with a trackpad? If you find that the wheel is reversed, please try:
The default is |
2019-12-12 16:43:36: afarr commented
|
2019-12-12 21:44:07: afarr commented
|
Assuming that this is the same version as in #2515, that's a Python2 / GTK2 build.
Cool. No need to invert horizontal scrolling on macos then?
We normalize the values we get from macos.
Right, add to that the fact that Javascript is likely to do its own normalization... fun!
Yes please. |
2019-12-17 00:33:25: afarr commented
|
Are you sure that another instance wasn't already running for this user account?
Bummer. I may have to borrow a windows laptop to debug this.
There wasn't one. But now there is: r24736 (+r24737 is swapping the default direction). New Fedora beta builds posted. Alternatively, you can use the latest copy of the html5 client here: [https://xpra.org/html5/connect.html]. I forgot to mention that to make things even more complicated, we also have 2 different ways of handling scrolling... |
2019-12-17 23:34:00: afarr commented
|
2019-12-17 23:40:46: afarr uploaded file
|
Damn, they've removed the
Right, the xterm selection syncs to PRIMARY, and there seems to be a problem when choosing PRIMARY with the win32 client - will fix.
Yeah, those are probably harmless.
I am pretty confident that this bug is already fixed: #2514. Grab a newer client and things should work. |
2020-01-02 20:18:20: afarr commented
|
2020-01-02 22:07:55: afarr commented
|
Until we know what solution works, r24736 + r24737 were only applied to trunk. Can you try that instead? The latest beta builds should have this change, or you can use the online copy here: [https://xpra.org/html5/].
I suspect that this requires special touch device event registration with GTK, I will need a trackpad device to test.
Damn. The 3.0.4 update was meant to fix that bug: #2466, which caused #2481, which caused #2491 which ended up fixing #2373... |
2020-01-03 21:30:33: afarr commented
|
Ah, r24903 fixes that. I don't really understand how it happened, but the values for horizontal scrolling now look like they should be the same in v3.0.x... (leaving them alone) but you're saying the backport is needed there!?
Can you please add your opengl info into #2466.
It shouldn't make any difference, the opengl probe happens before we try to connect. Odd. The new ticket below should make it clearer.
New ticket: #2540. |
2020-01-06 20:09:01: afarr commented
|
2020-01-09 23:37:18: afarr commented
|
Sorry about that, this bug was fixed yesterday in 24934. |
2020-01-21 20:27:32: afarr commented
|
Thanks!
Done in r25032. |
Follow up from #1611.
The text was updated successfully, but these errors were encountered: