Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of opengl fbo resize delay #2373

Closed
totaam opened this issue Jul 29, 2019 · 11 comments
Closed

get rid of opengl fbo resize delay #2373

totaam opened this issue Jul 29, 2019 · 11 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 29, 2019

Issue migrated from trac ticket # 2373

component: client | priority: major | resolution: fixed

2019-07-29 16:40:45: antoine created the issue


Aka XPRA_OPENGL_FBO_RESIZE_DELAY, added in r23338 for #2217.

There must be a more deterministic event we can wait for instead of using a timer. (which is not always long enough)

@totaam
Copy link
Collaborator Author

totaam commented Oct 28, 2019

2019-10-28 15:14:03: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Oct 28, 2019

2019-10-28 15:14:03: antoine commented


Could this be related to #2462?

@totaam
Copy link
Collaborator Author

totaam commented Nov 19, 2019

2019-11-19 15:53:30: antoine commented


See #2481: I believe the correct solution is very likely to be similar to the fixes from #2481, we have to use an expose event.
The backing knows nothing about the window, so hopefully we can just queue_draw_area on the backing directly?

@totaam
Copy link
Collaborator Author

totaam commented Nov 20, 2019

2019-11-20 12:07:46: antoine commented


The delay does not seem to be needed any more, so r24463 makes it optional and defaults to -1 (disabled).

@totaam
Copy link
Collaborator Author

totaam commented Nov 20, 2019

2019-11-20 12:17:33: antoine commented


Mostly reverted in r24464 as the bug still occurs on win32.

@totaam
Copy link
Collaborator Author

totaam commented Nov 21, 2019

2019-11-21 04:51:49: antoine commented


Should be fixed in r24465.

Just needs re-testing on all platforms..

@totaam
Copy link
Collaborator Author

totaam commented Nov 21, 2019

2019-11-21 05:54:57: antoine commented


Damn. Still occurs on macos...

@totaam
Copy link
Collaborator Author

totaam commented Dec 4, 2019

2019-12-04 11:20:32: antoine commented


Could probably be removed after the latest round of opengl / gtk3 paint fixes: r24577 (+ r24581 + r24576), except macos uses the XPRA_OPENGL_CONTEXT_REINIT=1 default, see #2491.

@totaam
Copy link
Collaborator Author

totaam commented Dec 4, 2019

2019-12-04 14:31:50: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Dec 4, 2019

2019-12-04 14:31:50: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Dec 4, 2019

2019-12-04 14:31:50: antoine commented


Disabled by default in r24592 following #2491#comment:10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant