ADA compliance #320
Open
ADA compliance #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add hidden span elements to nav buttons for ADA compliance
change TH tags surrounding nav buttons to TD tags and add hidden span elements for ADA compliance
|
@syntax53 would you be open to check if it works with the latest WP and PHP since this is a very old PR? |
rosinghal
requested changes
Jan 27, 2023
| <th class="simcal-nav simcal-prev-wrapper" colspan="<?php echo apply_filters( 'simcal_prev_cols', '1' ); ?>"> | ||
| <button class="simcal-nav-button simcal-month-nav simcal-prev" title="<?php _e( 'Previous Month', 'google-calendar-events' ); ?>"><i class="simcal-icon-left"></i></button> | ||
| </th> | ||
| <td class="simcal-nav simcal-prev-wrapper" colspan="<?php echo apply_filters( 'simcal_prev_cols', '1' ); ?>"> |
There was a problem hiding this comment.
Interested to know why this changed from th to td?
| <button class="simcal-nav-button simcal-month-nav simcal-prev" title="<?php _e( 'Previous Month', 'google-calendar-events' ); ?>"><i class="simcal-icon-left"></i></button> | ||
| </th> | ||
| <td class="simcal-nav simcal-prev-wrapper" colspan="<?php echo apply_filters( 'simcal_prev_cols', '1' ); ?>"> | ||
| <button class="simcal-nav-button simcal-month-nav simcal-prev" title="<?php _e( 'Previous Month', 'google-calendar-events' ); ?>"><i class="simcal-icon-left"></i><span style="display:none;"><?php _e( 'Previous Month', 'google-calendar-events' ); ?></span></button> |
There was a problem hiding this comment.
Can we use ARIA instead of adding a hidden text?
| @@ -204,6 +204,7 @@ public function html() { | |||
| echo "\t" . '<div class="simcal-nav">' . "\n"; | |||
| echo "\t\t" . '<button class="simcal-nav-button simcal-prev" title="' . __('Previous', 'google-calendar-events') . '"' . $disabled . '>' . "\n"; | |||
| echo "\t\t\t" . '<i class="simcal-icon-left"></i>' . "\n"; | |||
| echo "\t\t\t" . '<span style="display:none;">' . __('Previous', 'google-calendar-events') . '</span>' . "\n"; | |||
There was a problem hiding this comment.
Same here, can we can use ARIA in the above line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues with the NAV buttons and satisfying ADA compliance for web sites -- http://wave.webaim.org . These changes satisfy the checker.