Abort song load on failed validation (#592)

+ Updates YARG.Core

Assets/Script/Gameplay/GameManager.cs

@@ -69,7 +69,14 @@ public partial class GameManager : MonoBehaviour
 
         public bool IsSongStarted { get; private set; } = false;
 
-        private bool   _loadFailure;
+        private enum LoadFailureState
+        {
+            None,
+            Rescan,
+            Error
+        }
+
+        private LoadFailureState _loadState;
         private string _loadFailureMessage;
 
         // All access to chart data must be done through this event,
@@ -201,7 +208,14 @@ private async UniTaskVoid Start()
             LoadingManager.Instance.Queue(LoadAudio, "Loading audio...");
             await LoadingManager.Instance.StartLoad();
 
-            if (_loadFailure)
+            if (_loadState == LoadFailureState.Rescan)
+            {
+                ToastManager.ToastWarning("Chart requires a rescan!");
+                GlobalVariables.Instance.LoadScene(SceneIndex.Menu);
+                return;
+            }
+
+            if (_loadState == LoadFailureState.Error)
             {
                 Debug.LogError(_loadFailureMessage);
                 ToastManager.ToastError(_loadFailureMessage);
@@ -370,17 +384,18 @@ private async UniTask LoadReplay()
             }
             catch (Exception ex)
             {
-                _loadFailure = true;
+                _loadState = LoadFailureState.Error;
                 _loadFailureMessage = "Failed to load replay!";
                 Debug.LogException(ex, this);
                 return;
             }
 
             Song = GlobalVariables.Instance.SongContainer.SongsByHash[
                 GlobalVariables.Instance.CurrentReplay.SongChecksum][0];
+
             if (Song is null || result != ReplayReadResult.Valid)
             {
-                _loadFailure = true;
+                _loadState = LoadFailureState.Error;
                 _loadFailureMessage = "Failed to load replay!";
                 return;
             }
@@ -411,12 +426,18 @@ await UniTask.RunOnThreadPool(() =>
                 }
                 catch (Exception ex)
                 {
-                    _loadFailure = true;
+                    _loadState = LoadFailureState.Error;
                     _loadFailureMessage = "Failed to load chart!";
                     Debug.LogException(ex, this);
                     return;
                 }
 
+                if (Chart is null)
+                {
+                    _loadState = LoadFailureState.Rescan;
+                    return;
+                }
+
                 // Ensure sync track is present
                 var syncTrack = Chart.SyncTrack;
                 if (syncTrack.Beatlines is null or { Count: < 1 })
@@ -433,7 +454,8 @@ await UniTask.RunOnThreadPool(() =>
                 }
             });
 
-            if (_loadFailure) return;
+            if (_loadState != LoadFailureState.None)
+                return;
 
             _chartLoaded?.Invoke(Chart);
         }
@@ -453,13 +475,14 @@ await UniTask.RunOnThreadPool(() =>
                 }
                 catch (Exception ex)
                 {
-                    _loadFailure = true;
+                    _loadState = LoadFailureState.Error;
                     _loadFailureMessage = "Failed to load audio!";
                     Debug.LogException(ex, this);
                 }
             });
 
-            if (_loadFailure) return;
+            if (_loadState != LoadFailureState.None)
+                return;
 
             _songLoaded?.Invoke();
         }