Implement collective debounce across all controls on a button binding, along with displays for collective value on bindings #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would put the debounce treshold to a default value of 1/2/5ms as discussed. |
|
With this PR, I'm unable to add new bindings. Also, the shadows on the drawers looks a little too dark imo |
TheNathannator
force-pushed
the
button-collective-debounce
branch
from
f0292e0
to
2629d4e
Compare
|
Binding addition should be fixed now. As for the shadows, tbh I can hardly even notice them in the editor lol, if the menu background was more transparent I'd be able to see them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new debounce behaves the same as the one for individual controls: when a value change occurs, it will lock to that new state for the configured amount of time, keeping track of any further state changes during that time. Once that time expires, it will switch back to the tracked state, and when the next input comes in it repeats the process.
All binding types also now have displays for their current value, for parity with the individual bindings and to help with figuring out possible input issues.