Trill and Tremolo Lanes #909
Open
+1,886
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created TrackPlayer pool for lane elements Rendering behavior for lanes Remove DetectLanes usage Create separate prefabs for pro keys overlay colors and pro keys white key highlights. Use only overlay material for overlays, and use only highlight material for highlights Use flag booleans instead of comparing flags Replace separate lane components with single mesh and armature Material sorting order adjustments after lane model change
|
Refer to the previous PR for reasoning behind the Unity prefab and material changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires YARG.Core PR 222.
Assets and rendering behavior for trill and tremolo lanes.