Highlight downloaded regions #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrgernoe
requested changes
Dec 20, 2021
There was a problem hiding this comment.
- I would not add the tick in front of the downloaded regions. In my eyes this makes the layout a bit nervous. My suggestions would be to add an empty box in front of each item but mark it as check, if downloaded.
- Please don't introduce a "completely" new color. There is a link in the color definition file that describes the color scheme which is used in the app. Please keep with this color either within the primary or secondary color "space".
chrgernoe
reviewed
Dec 20, 2021
app/src/main/res/values/colors.xml
Outdated
| @@ -38,6 +38,7 @@ | |||
| <color name="colorOnSecondaryLight">@color/colorSecondaryDark</color> | |||
| <color name="colorOnSecondaryDark">@color/white</color> | |||
|
|
|||
| <color name="colorDownloaded">#ddeeff</color> | |||
There was a problem hiding this comment.
Use a more general name so that this color can also be used on other places in the app.
Hm, I tried the secondary color, but this is a bit confusing since grey color means "prohibited" in the other views. I'll choose a light color from our "Indigo" color scheme and define it as a new color, I hope that's ok. |
chrgernoe
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #278