Migrated sector list to recycler view #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paetz
force-pushed
the
feature/304_migrate_sector_list_to_recycler_view
branch
from
fddfe08
to
4df09b6
Compare
chrgernoe
previously approved these changes
Feb 6, 2022
Comment on lines
44
to
51
| private val _countSummits = customSettings.getBoolean(context.getString(R.string.count_summits), context.resources.getBoolean(R.bool.count_summits)) | ||
| private val _countMassifs = customSettings.getBoolean(context.getString(R.string.count_massifs), context.resources.getBoolean(R.bool.count_massifs)) | ||
| private val _countBoulders = customSettings.getBoolean(context.getString(R.string.count_boulders), context.resources.getBoolean(R.bool.count_boulders)) | ||
| private val _countCaves = customSettings.getBoolean(context.getString(R.string.count_caves), context.resources.getBoolean(R.bool.count_caves)) | ||
| private val _countUnofficialRocks = customSettings.getBoolean(context.getString(R.string.count_unofficial_rocks), context.resources.getBoolean(R.bool.count_unofficial_rocks)) | ||
| private val _countProhibitedRocks = customSettings.getBoolean(context.getString(R.string.count_prohibited_rocks), context.resources.getBoolean(R.bool.count_prohibited_rocks)) | ||
| private val _countCollapsedRocks = customSettings.getBoolean(context.getString(R.string.count_collapsed_rocks), context.resources.getBoolean(R.bool.count_collapsed_rocks)) | ||
| private val _countOnlyLeads = customSettings.getBoolean(context.getString(R.string.count_only_leads), context.resources.getBoolean(R.bool.count_only_leads)) |
There was a problem hiding this comment.
It is pretty hard to read. I would prefer to break the lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #304