Add view that lists all used libraries and their licenses #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paetz
requested changes
Jan 3, 2023
app/src/main/java/com/yacgroup/yacguide/AboutLibrariesActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/yacgroup/yacguide/AboutLibrariesActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/yacgroup/yacguide/AboutLibrariesActivity.kt
Outdated
Show resolved
Hide resolved
| @@ -43,6 +43,11 @@ class AboutActivity : BaseNavigationActivity() { | |||
| _createEntry(getString(R.string.privacy_policy), callback = { _showPrivacyPolicy() }) | |||
| _createEntry(getString(R.string.source_code_and_support), getString(R.string.github_url)) | |||
| _createEntry(getString(R.string.license), getString(R.string.license_url)) | |||
| _createEntry( | |||
There was a problem hiding this comment.
Might it make sense to migrate this view to RecyclerView using BaseViewItemAdapter, too? If yes, you may create a ticket for that.
There was a problem hiding this comment.
I will have a look. Thanks for the hint.
paetz
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
For some reason, the license for the Apache Commons CSV library is empty. It is under clarification in issue mikepenz/AboutLibraries#827. Since the information are generated automatically during each build, it should not be a blocker to merge this issue.