Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show failed regions on update error #391

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Show failed regions on update error #391

merged 3 commits into from
Jan 18, 2023

Conversation

paetz
Copy link
Collaborator

@paetz paetz commented Jan 12, 2023

Resolves #55

@paetz paetz requested a review from chrgernoe January 12, 2023 14:02
@github-actions github-actions bot added the feature New feature or request label Jan 12, 2023
@paetz paetz force-pushed the feature/55_make_update_error_more_transparent branch from 57299ca to 99c0ac4 Compare January 16, 2023 13:35
chrgernoe
chrgernoe previously approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@chrgernoe chrgernoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume, I know what you do because for me this change is a bit hard to understand.

app/src/main/java/com/yacgroup/yacguide/utils/DataUId.kt Outdated Show resolved Hide resolved
app/src/main/java/com/yacgroup/yacguide/network/SectorParser.kt Outdated Show resolved Hide resolved
app/src/main/java/com/yacgroup/yacguide/network/SectorParser.kt Outdated Show resolved Hide resolved
@paetz
Copy link
Collaborator Author

paetz commented Jan 17, 2023

I assume, I know what you do because for me this change is a bit hard to understand.

I basically open a dialog on failed updates in which I list all failed regions. For this, I need to somehow remember the requested regions via this DataUid struct.

@chrgernoe
Copy link
Member

I assume, I know what you do because for me this change is a bit hard to understand.

I basically open a dialog on failed updates in which I list all failed regions. For this, I need to somehow remember the requested regions via this DataUid struct.

OK. My first impression was that code got more complicated because you added arguments to methods where no argument was before.

@paetz paetz merged commit d87f617 into master Jan 18, 2023
@paetz paetz deleted the feature/55_make_update_error_more_transparent branch January 18, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrgernoe chrgernoe chrgernoe left review comments

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make update error more transparent
2 participants
@paetz @chrgernoe