New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow override onShowMore callback (#1214) #3

Merged

Yadro merged 1 commit into Yadro:master from jquense:master

Feb 19, 2019

Owner

Yadro commented Feb 19, 2019

I've replaced this._showMore by callback from props. Seems it was added by mistake here, _showMore is always undefined.

Here it will be execute:
https://github.com/intljusticemission/react-big-calendar/blob/1d62c432eaa183ed6b38f08cfcec5ee7edcbfe41/src/Month.js#L300-L307

Related to jquense#1147


          fix: allow override onShowMore callback (#1214)

8fefeee

I've replaced `this._showMore` by callback from props. Seems it was added by mistake [here](https://github.com/intljusticemission/react-big-calendar/blob/f9a873368a78f5ced81b799c4dffe1095b3ab712/src/Calendar.jsx#L280), `_showMore` is always undefined.

Here it will be execute:
https://github.com/intljusticemission/react-big-calendar/blob/1d62c432eaa183ed6b38f08cfcec5ee7edcbfe41/src/Month.js#L300-L307

Related to #1147

Yadro merged commit 7512194 into Yadro:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet