This repository has been archived by the owner on Sep 5, 2018. It is now read-only.
decoupled from depending on exphbs.compileTemplate #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
@neraliu, please review. Thanks. |
| xssFilters = require('xss-filters'), | ||
| privateFilters = xssFilters._privFilters, | ||
| ContextParserHandlebars = require("context-parser-handlebars"); | ||
| secureHandlebars = require('./secure-handlebars'); |
There was a problem hiding this comment.
Good! we can simply create the secure-handlebars and replace this line later.
neraliu
added a commit
that referenced
this pull request
Mar 17, 2015
decoupled from depending on exphbs.compileTemplate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: ericf/express-handlebars#105 is going to break the public API
An equivalent compile/precompile functions are now made "protected"
Hence, we should directly override the compile/precompile functions of Handlebars, and made the patched Handlebars a parameter of express-handlebars. In view of this, I'm separating the necessary patches to secure-handlebars.js, which can later be forked and made standalone for a new package secure-handlebars.
But anyway, the following changes can work well with both the current version of express-handlebars, and its forthcoming PR 105. And in this particular change, we're able to make way for handlebars 3.0 directly.