Fix missing library dependencies on Linux #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configured to use GCC or Clang to build yaksha on Linux, it seems like many parts of the runtime are depending on `pthread`. Similarily, the main `yaksha` binary depends on `libdl`. This patch adds the missing library dependencies when building on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configured to use GCC or Clang to build yaksha on Linux, it seems like many parts of the runtime are depending on
pthread. Similarily, the mainyakshabinary depends onlibdl. Not sure if you usedzig ccto build the project and this was not a issue with that toolchain, but I thought it will be more convenient to make Yaksha buildable using system compilers.This patch adds the missing library dependencies when building on Linux. More specifically, since the
LIBSvariable in the cmake script was actually never initialized, I renamed it toSYS_LIBSand used it to specify those missing libraries on Linux. Theoretically this won't break the existing Windows buildbot.