adapt Android10/Q #606
adapt Android10/Q #606
Conversation
| } | ||
| Bitmap decodeSampledBitmap = null; | ||
| ContentResolver resolver = mContext.getContentResolver(); | ||
| if (mBeforeAndroidQ) { |
There was a problem hiding this comment.
It's unnecessary check, it's not really needed to use file descriptor. We fixed this in our fork, you can take a look
There was a problem hiding this comment.
Thanks, I just considered Android10 compatibility. I looked at your fork and did a simple test, and it worked fine. Why is pr closed?
There was a problem hiding this comment.
We just didn't have time to prepare proper PR, but we plan to do that. Also those changes changed behavior, image is not saved anymore to Downloads, it should be documented
There was a problem hiding this comment.
One more thing, to make a proper fix, you should send PR not to master, but to develop AND to feature/non_native branches, because non-native and native versions of the lib are essentially forks
There was a problem hiding this comment.
Yes, I found UCrop's jni in my project. I haven’t had time to modify it. I will close this pr and use your solution in my project.
There was a problem hiding this comment.
After several hours of incomplete testing, I came to the conclusion that your plan is more time-consuming. There are two main points: 1. CopyFile is executed regardless of the version, which increases the time 2. decodeStream is more time-consuming than decodeFileDescriptor
There was a problem hiding this comment.
This is the only correct way anyway. copyFile is required because it's used by other parts of the app. Using file descriptor is just incorrect
There was a problem hiding this comment.
Also, are you sure that your measurement is correct and you don't forget to include copyFile function, because it's required and for old and for new code
There was a problem hiding this comment.
I don't quite agree with FileDescriptor's incorrect statement (I want to know why), because UCrop was at least available before Android10. Then there is the issue of time. Even if you add the copy application time to the version that does not use copyFile, it still saves a little time. Of course, I only tested 2 phones.
There was a problem hiding this comment.
UCrop was at least available before Android10
I don't say that it will not work, it's just too hacky, and broken work with Android 10 proofs this. ContentResolve is the only correct and intended by Android framework way to do that
|
As discussed above |
As the title