[fuchsia] Add a basic WebGL test to cast runner

Add a new test that creates a WebGL context which depends on an initialized GPU process. Some other tests are able to pass before the GPU process initializes which creates flaky failures if a GPU process startup crash is introduced. Bug: 1059979, 766360 Change-Id: I7d144b1a0e2b39cd9f7de80a5532eb56a35a209f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152209 Commit-Queue: Michael Spang <[email protected]> Reviewed-by: David Dorwin <[email protected]> Reviewed-by: Wez <[email protected]> Cr-Commit-Position: refs/heads/master@{#760703}
Yannic · Apr 20, 2020 · 07ba894 · 07ba894
1 parent 0a64d6a
commit 07ba894
Show file tree

Hide file tree

Showing 3 changed files with 78 additions and 8 deletions.
diff --git a/build/config/fuchsia/tests-with-exec.cmx b/build/config/fuchsia/tests-with-exec.cmx
@@ -33,6 +33,7 @@
       "fuchsia.sysmem.Allocator",
       "fuchsia.ui.input.ImeService",
       "fuchsia.ui.input.ImeVisibilityService",
+      "fuchsia.vulkan.loader.Loader",
       "fuchsia.web.ContextProvider"
     ]
   }

diff --git a/fuchsia/runners/cast/cast_runner_integration_test.cc b/fuchsia/runners/cast/cast_runner_integration_test.cc
@@ -25,6 +25,7 @@
 #include "base/test/bind_test_util.h"
 #include "base/test/task_environment.h"
 #include "base/threading/sequenced_task_runner_handle.h"
+#include "build/build_config.h"
 #include "fuchsia/base/agent_impl.h"
 #include "fuchsia/base/context_provider_test_connector.h"
 #include "fuchsia/base/fake_component_context.h"
@@ -201,7 +202,9 @@ class FakeComponentState : public cr_fuchsia::AgentImpl::ComponentStateBase {
 
 class CastRunnerIntegrationTest : public testing::Test {
  public:
-  CastRunnerIntegrationTest() : CastRunnerIntegrationTest(/*headless=*/false) {}
+  CastRunnerIntegrationTest()
+      : CastRunnerIntegrationTest(/*enable_headless=*/false,
+                                  /*enable_vulkan=*/false) {}
   CastRunnerIntegrationTest(const CastRunnerIntegrationTest&) = delete;
   CastRunnerIntegrationTest& operator=(const CastRunnerIntegrationTest&) =
       delete;
@@ -216,7 +219,7 @@ class CastRunnerIntegrationTest : public testing::Test {
   }
 
  protected:
-  explicit CastRunnerIntegrationTest(bool headless)
+  explicit CastRunnerIntegrationTest(bool enable_headless, bool enable_vulkan)
       : app_config_manager_binding_(&component_services_,
                                     &app_config_manager_) {
     EnsureFuchsiaDirSchemeInitialized();
@@ -225,9 +228,11 @@ class CastRunnerIntegrationTest : public testing::Test {
     fuchsia::web::ContextFeatureFlags feature_flags =
         fuchsia::web::ContextFeatureFlags::NETWORK |
         fuchsia::web::ContextFeatureFlags::LEGACYMETRICS;
-    if (headless) {
-      feature_flags =
-          feature_flags | fuchsia::web::ContextFeatureFlags::HEADLESS;
+    if (enable_headless) {
+      feature_flags |= fuchsia::web::ContextFeatureFlags::HEADLESS;
+    }
+    if (enable_vulkan) {
+      feature_flags |= fuchsia::web::ContextFeatureFlags::VULKAN;
     }
 
     WebContentRunner::GetContextParamsCallback get_context_params =
@@ -243,8 +248,8 @@ class CastRunnerIntegrationTest : public testing::Test {
               CastRunner::kRemoteDebuggingPort);
           return create_context_params;
         });
-    cast_runner_ =
-        std::make_unique<CastRunner>(std::move(get_context_params), headless);
+    cast_runner_ = std::make_unique<CastRunner>(std::move(get_context_params),
+                                                enable_headless);
     cast_runner_->PublishRunnerService(&outgoing_directory_);
 
     StartAndPublishWebEngine();
@@ -790,7 +795,8 @@ TEST_F(CastRunnerIntegrationTest, MicrophoneRedirect) {
 class HeadlessCastRunnerIntegrationTest : public CastRunnerIntegrationTest {
  public:
   HeadlessCastRunnerIntegrationTest()
-      : CastRunnerIntegrationTest(/*headless=*/true) {}
+      : CastRunnerIntegrationTest(/*enable_headless=*/true,
+                                  /*enable_vulkan=*/false) {}
 };
 
 // A basic integration test ensuring a basic cast request launches the right
@@ -853,3 +859,61 @@ TEST_F(CastRunnerIntegrationTest, LegacyMetricsRedirect) {
       base::Unretained(&component_state_), run_loop.QuitClosure());
   run_loop.Run();
 }
+
+TEST_F(CastRunnerIntegrationTest, WebGLContextAbsentWithoutVulkanFeature) {
+  const char kTestPath[] = "/webgl_presence.html";
+  const GURL test_url = test_server_.GetURL(kTestPath);
+  app_config_manager_.AddApp(kTestAppId, test_url);
+
+  CreateComponentContextAndStartComponent();
+
+  EXPECT_EQ(ExecuteJavaScript("document.title"), "absent");
+}
+
+TEST_F(CastRunnerIntegrationTest,
+       WebGLContextAbsentWithoutVulkanFeature_IsolatedRunner) {
+  const GURL kContentDirectoryUrl("fuchsia-dir://testdata/webgl_presence.html");
+
+  RegisterAppWithTestData(kContentDirectoryUrl);
+  CreateComponentContextAndStartComponent();
+  CheckAppUrl(kContentDirectoryUrl);
+
+  EXPECT_EQ(ExecuteJavaScript("document.title"), "absent");
+}
+
+#if defined(ARCH_CPU_ARM_FAMILY)
+// TODO(crbug.com/1058247): Support Vulkan in tests on ARM64.
+#define MAYBE_VulkanCastRunnerIntegrationTest \
+  DISABLED_VulkanCastRunnerIntegrationTest
+#else
+#define MAYBE_VulkanCastRunnerIntegrationTest VulkanCastRunnerIntegrationTest
+#endif
+
+class MAYBE_VulkanCastRunnerIntegrationTest : public CastRunnerIntegrationTest {
+ public:
+  MAYBE_VulkanCastRunnerIntegrationTest()
+      : CastRunnerIntegrationTest(/*enable_headless=*/false,
+                                  /*enable_vulkan=*/true) {}
+};
+
+TEST_F(MAYBE_VulkanCastRunnerIntegrationTest,
+       WebGLContextPresentWithVulkanFeature) {
+  const char kTestPath[] = "/webgl_presence.html";
+  const GURL test_url = test_server_.GetURL(kTestPath);
+  app_config_manager_.AddApp(kTestAppId, test_url);
+
+  CreateComponentContextAndStartComponent();
+
+  EXPECT_EQ(ExecuteJavaScript("document.title"), "present");
+}
+
+TEST_F(MAYBE_VulkanCastRunnerIntegrationTest,
+       WebGLContextPresentWithVulkanFeature_IsolatedRunner) {
+  const GURL kContentDirectoryUrl("fuchsia-dir://testdata/webgl_presence.html");
+
+  RegisterAppWithTestData(kContentDirectoryUrl);
+  CreateComponentContextAndStartComponent();
+  CheckAppUrl(kContentDirectoryUrl);
+
+  EXPECT_EQ(ExecuteJavaScript("document.title"), "present");
+}
diff --git a/fuchsia/runners/cast/testdata/webgl_presence.html b/fuchsia/runners/cast/testdata/webgl_presence.html
@@ -0,0 +1,5 @@
+<script>
+  var canvas = document.createElement("canvas");
+  var gl = canvas.getContext("webgl");
+  document.title = gl ? "present" : "absent";
+</script>