Add a new DiagnosticGroup: unnecessaryEscape

This gives feedback when JS strings contain backslash escapes that aren't meaningful and are silently ignored. This can catch real issues, and is quite useful. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=160464984
Yannic · Jul 6, 2017 · 1f6810d · 1f6810d
1 parent 12836b7
commit 1f6810d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/com/google/javascript/jscomp/DiagnosticGroups.java b/src/com/google/javascript/jscomp/DiagnosticGroups.java
@@ -599,6 +599,9 @@ public DiagnosticGroup forName(String name) {
       DiagnosticGroups.registerGroup("jsdocMissingType",
               RhinoErrorReporter.JSDOC_MISSING_TYPE_WARNING);
 
+  public static final DiagnosticGroup UNNECESSARY_ESCAPE =
+      DiagnosticGroups.registerGroup("unnecessaryEscape", RhinoErrorReporter.UNNECESSARY_ESCAPE);
+
   // Warnings reported by the linter. If you enable these as errors in your build targets,
   // the JS Compiler team will break your build and not rollback.
   public static final DiagnosticGroup LINT_CHECKS =
@@ -633,7 +636,6 @@ public DiagnosticGroup forName(String name) {
               ClosureCheckModule.REFERENCE_TO_FULLY_QUALIFIED_IMPORT_NAME,
               ClosureCheckModule.REFERENCE_TO_SHORT_IMPORT_BY_LONG_NAME_INCLUDING_SHORT_NAME,
               ClosureRewriteModule.USELESS_USE_STRICT_DIRECTIVE,
-              RhinoErrorReporter.UNNECESSARY_ESCAPE,
               RhinoErrorReporter.JSDOC_MISSING_BRACES_WARNING));
 
   static final DiagnosticGroup STRICT_MODULE_CHECKS =

diff --git a/src/com/google/javascript/jscomp/Linter.java b/src/com/google/javascript/jscomp/Linter.java
@@ -87,6 +87,7 @@ static void lint(Path path, Compiler compiler) throws IOException {
     options.setWarningLevel(DiagnosticGroups.CHECK_TYPES, CheckLevel.WARNING);
 
     options.setWarningLevel(DiagnosticGroups.JSDOC_MISSING_TYPE, CheckLevel.ERROR);
+    options.setWarningLevel(DiagnosticGroups.UNNECESSARY_ESCAPE, CheckLevel.WARNING);
     options.setWarningLevel(DiagnosticGroups.LINT_CHECKS, CheckLevel.WARNING);
     options.setWarningLevel(DiagnosticGroups.UNUSED_LOCAL_VARIABLE, CheckLevel.WARNING);
     options.setWarningLevel(DiagnosticGroups.STRICT_MISSING_REQUIRE, CheckLevel.ERROR);

diff --git a/test/com/google/javascript/jscomp/IntegrationTest.java b/test/com/google/javascript/jscomp/IntegrationTest.java
@@ -4280,7 +4280,7 @@ public void testUnnecessaryBackslashInStringLiteral() {
 
   public void testWarnUnnecessaryBackslashInStringLiteral() {
     CompilerOptions options = createCompilerOptions();
-    options.setWarningLevel(DiagnosticGroups.LINT_CHECKS, CheckLevel.WARNING);
+    options.setWarningLevel(DiagnosticGroups.UNNECESSARY_ESCAPE, CheckLevel.WARNING);
     test(options,
         "var str = '\\q';",
         "var str = 'q';",