Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of error (sub)codes #60

Open
ted-miller opened this issue Jun 14, 2023 · 1 comment
Open

Reuse of error (sub)codes #60

ted-miller opened this issue Jun 14, 2023 · 1 comment
Labels
rv:0.1.0 Reported in MotoROS2 0.1.0 todo Not an issue, just a TODO

Comments

@ted-miller
Copy link
Collaborator

There are multiple instances of the SUBCODE_FAIL_MP_NICDATA error code in different source files. Although they both essentially have the same meaning, it is impossible to know exactly which line of code raised the error. This makes troubleshooting more difficult.

We should go through and make sure that no error code is repeated anywhere in the code.

SUBCODE_FAIL_MP_NICDATA instances:

SUBCODE_FAIL_MP_NICDATA,

and

SUBCODE_FAIL_MP_NICDATA,

@ted-miller ted-miller added rv:0.1.0 Reported in MotoROS2 0.1.0 todo Not an issue, just a TODO labels Jun 14, 2023
@gavanderhoorn gavanderhoorn changed the title Multiple instances of error code Reuse of error (sub)codes Jun 16, 2023
@gavanderhoorn
Copy link
Collaborator

gavanderhoorn commented Jul 10, 2023

I've got something for this in main...gavanderhoorn:motoros2:platform_lib_update_v210.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rv:0.1.0 Reported in MotoROS2 0.1.0 todo Not an issue, just a TODO
Projects
None yet
Development

No branches or pull requests

2 participants