Update PlatformLib to v0.2.10 (resubmit for CI)
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define 3 new subcodes and use them with the appropriate motoRosAssert(..).
ted-miller
requested changes
Jul 13, 2023
ted-miller
previously approved these changes
Jul 14, 2023
ted-miller
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a replacement for #89 to get CI working (secrets don't work for workflows triggered by events from forks))
As per subject.
Only build-tested (but we'll see what CI thinks of it), although we have tested
thissimilar versions of the platform lib as part of #49.0ec05f5 adds the changes necessary to use the new version of
Ros_GetMacAddress(..)(which now requires an argument to indicate for which interface the MAC should be retrieved).e202c7f addresses #60, at least for
SUBCODE_FAIL_MP_NICDATA(it was used 4 times in total).