Fix Ros_Controller_GetActiveAlarmCodes(..)
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But only if it hasn't been defined already. According to available information, there can only ever be a single active error at the same time, so set it to 1.
It's actually just the error code itself. MAX_ERROR_COUNT is always 1 (on supported generations of controllers), but let's still treat it as something that can change, to facilitate future updates.
gavanderhoorn
commented
Aug 1, 2023
ted-miller
reviewed
Aug 1, 2023
This is needed as otherwise MAX_ERROR_COUNT is undefined when we use it in the ControllerStatusIO.h header.
gavanderhoorn
force-pushed
the
fix_get_active_alarm_codes
branch
from
fda7eae
to
53f16d2
Compare
|
I don't know how to (reliably, easily) trigger an |
Just push PLAY when the robot is in TEACH mode. I tested. All good. |
ted-miller
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104.
Should fix it, at least. I haven't had an opportunity to test it.